Donald F. McGahn, now President Donald Trump’s White House counsel, made $2.4 million as a lawyer with a client list loaded with deep-pocketed conservative groups, from Americans for Prosperity, backed by the conservative billionaires Charles G.